(fix) O3-3890 Help menu (and menu items) should use a standard Carbon… #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
denniskigen
reviewed
Oct 5, 2024
| {t('docs', 'Docs')} | ||
| </Link> | ||
| label={t('documentation', 'Documentation')} | ||
| onClick={() => window.open('https://o3-docs.openmrs.org', '_blank')} |
There was a problem hiding this comment.
Can we move the onClick handler to a function that's wrapped in a useCallback hook?
There was a problem hiding this comment.
I wouldn’t expect these changes to be included here. Bad rebase?
There was a problem hiding this comment.
Yes, a mistake on my end, I'll fix it
denniskigen
reviewed
Oct 5, 2024
| {t('communityforum', 'Community forum')} | ||
| </Link> | ||
| label={t('communityforum', 'Community forum')} | ||
| onClick={() => window.open('https://talk.openmrs.org', '_blank')} |
There was a problem hiding this comment.
Can we wrap the onClick handlers in use callback hooks? Additionally, for security, it’s good to add noreferrer noopener to external links:
const handleClick = useCallback(() => {
window.open('https://talk.openmrs.org', '_blank', 'noopener,noreferrer');
}, [url]);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
I have updated the help menu to use standard carbon menu items. This PR is related to this PR openmrs/openmrs-esm-user-onboarding#21
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3890
Other